-
Notifications
You must be signed in to change notification settings - Fork 41
chore: bump py-spy to 0.4.1 #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump py-spy to 0.4.1 #251
Conversation
|
|
|
may need to bump rust toolchain to fix CI |
Cargo.lock
Outdated
| [[patch.unused]] | ||
| name = "py-spy" | ||
| version = "0.4.0" | ||
| source = "git+https://github.com/grafana/py-spy?rev=062d827#062d8279c15e949f507e22dce17414ab083ef477" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if git+https://github.com/grafana/ should be rebased against 0.4.1?
I've bumped rust to 1.87, also I think that |
|
We need to check if we can remove the fork altogether if they fixed the panic with line numbers paraing |
I’ve tested it without the patch, and it appears to work correctly with Python 3.12. I don’t have the exact repro steps, but the issue seems resolved upstream: I’ve removed the patch from the PR. |
Summary
This PR upgrades py-spy to version 0.4.1.
Context
The previous version of py-spy had compatibility issues with Python 3.12, preventing pyroscope-io from properly attaching to subprocesses. As a result, only the main process was profiled, leading to incomplete performance data.
Fix
Version 0.4.1 addresses this issue, ensuring full support for profiling subprocesses under Python 3.12.
See the upstream issue for details: benfred/py-spy#726.